[FME-10127] Add track method and setContext with targetingKey#8
Merged
ZamoraEmmanuel merged 1 commit intodevelopmentfrom Sep 29, 2025
Merged
[FME-10127] Add track method and setContext with targetingKey#8ZamoraEmmanuel merged 1 commit intodevelopmentfrom
ZamoraEmmanuel merged 1 commit intodevelopmentfrom
Conversation
EmilianoSanchez
requested changes
Sep 24, 2025
| } | ||
|
|
||
| async onClose?(): Promise<void> { | ||
| return this.client.destroy(); |
Contributor
There was a problem hiding this comment.
Check if this should be for all clients. We can use this.factory.destroy();
There was a problem hiding this comment.
I second this. I think we should destroy the factory in the onClose
EmilianoSanchez
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
targetingKeyandtrafficTypevalue updates using openFeaturesetContextmethod@splitsoftware/splitio-browserjsfrom1.3.1to1.4.0